search

hyperdefined / CustomLauncherRewrite

An all purpose custom TTR launcher.
GNU General Public License v3.0
5 stars 1 forks source link

[Bug] Cannot update TTR #116

Closed ahmouse15 closed 1 month ago

ahmouse15 commented 1 month ago

The TTR patch manifest URL was changed from https://cdn.toontownrewritten.com/content/patchmanifest to https://cdn.toontownrewritten.com/content/patchmanifest.txt

Rather, the second URL has been around for a while, but the former was just (intentionally?) removed and also happens to be what CLR uses, so at the moment patch manifests cannot be retrieved.

In fact, CLR should listen to the manifest field that's sent alongside the play cookie, which provides the patch manifest URL as described here

hyperdefined commented 1 month ago

CLR already loads the manifest from the login response (see https://github.com/hyperdefined/CustomLauncherRewrite/blob/master/src/main/java/lol/hyper/customlauncher/login/LoginHandler.java#L117).

I just tried launching the game myself, and got this response back:

{cookie=xxx, success=true, manifest=/content/patchmanifest, gameserver=45.77.79.152}

CLR sees the manifest and appends it to https://cdn.toontownrewritten.com as the API docs state. It seems like this is not a CLR problem but a TTR issue.

ahmouse15 commented 1 month ago

Oh very interesting. Since its the API's fault, I tried the official launcher to see if it would fail as well, but it worked just fine which is odd. After some digging it seems their launcher hardcodes the URL with patchmanifest.txt, ignoring the manifest field completely!

So, the API and their docs are misaligned again. I'll open a bug on their repo, hopefully it's fixed quickly like last time.

ahmouse15 commented 1 month ago

Fixed. See https://github.com/ToontownRewritten/api-doc/issues/24