search

hyperdefined / CustomLauncherRewrite

An all purpose custom TTR launcher.
GNU General Public License v3.0
5 stars 1 forks source link

Fix issues preventing game launch #95

Closed ahmouse15 closed 5 months ago

ahmouse15 commented 5 months ago

This PR fixes a chain of issues which prevented logging into the game.

Password formatting bug 656b1c9c67348585738d05e22c82df302d0e4d47

Fixed a bug where passwords were stored as a string containing an array (e.g. "[p, a, s, s, w, o, r, d]") causing logins to fail due to the incorrect password. I assume this is not the intended format, so I reverted it back to regular strings.

Handle null values in login response (due to newly added field) 253bae1d6d7d124d02b909a0578942653f9c53e6

This prevented login, since TTR just added a new field to their response field, ip, which is always null for now since its not being used yet. This broke CLR, so I added some logic to handle null response fields.

Move update check after Linux permission check 5b7201d55232c3ace5e5c34bc04b8d354dace04e

This prevents a bug which prevented login on fresh Linux installs due to checking file permissions before the files existed.

Allow whitespace in usernames 530de46d7bb9ade9d864972744150af7d34dc151

Since TTR does in fact allow spaces (and one of my accounts has a space in it, too).

With that said, a new release incorporating this + your 300 commits of updates would be awesome :)

hyperdefined commented 5 months ago

Hey! It's great to see you again contributing.

  1. Password formatting bug - didn't even catch this one, so thank you.
  2. Handle null values in login response - they must of just added this within the week, as I was able to login fine a week ago. Wonder what they are going to use this new field for, but null checking is something I didn't even think of.
  3. Move update check after Linux permission check - This was just a simple out of order operation. I swapped where the game updates since TTR now sends a patch manifest file on login, so I update after you login, and didn't account for Linux permissions checking.
  4. Allow whitespace in usernames - I figured they only allowed letters and numbers, but I guess I was wrong. That's neat.

Thanks for the help, I can release a new update soon. It has been over a year and I've changed a lot of things, so it should be time now.

hyperdefined commented 5 months ago

Looks like the new ip field was just a test and removed: https://github.com/ToontownRewritten/api-doc/issues/17