hyperdevs-team / poeditor-android-gradle-plugin

Gradle plug-in that enables importing PoEditor localized strings directly to an Android project
Apache License 2.0
51 stars 26 forks source link

Dekekt output is not clear when it fails #41

Open adriangl opened 3 years ago

adriangl commented 3 years ago

SW details (please complete the following information):

Summary and background of the bug As reported by @nokite in #37:

Btw I often have trouble with detekt. Like now when merging master into my branch. When there's a problem and the commit/merge commit is blocked, the error output is hard to read, it's all in one line šŸ™‚ Maybe it's not correctly set up on my machine, didn't spend time on this.

Here's some output. In this case it's actually pretty short, but normally it also mentions some formatting/complexity warnings etc. (and it's all in one line)

Couldn't check the working tree for unmerged files because of an error. tput: No value for $TERM and no -T specified tput: No value for $TERM and no -T specified tput: No value for $TERM and no -T specified tput: No value for $TERM and no -T specified Running detekt > Task :detekt UP-TO-DATE Deprecated Gradle features were used in this build, making it incompatible with Gradle 7.0. Use '--warning-mode all' to show the individual deprecation warnings. See https://docs.gradle.org/6.9/userguide/command_line_interface.html#sec:command_line_warnings BUILD SUCCESSFUL in 814ms 1 actionable task: 1 up-to-date Your code is properly formatted! could not read log file '/Users/.../poeditor-android-gradle-plugin/.git/MERGE_MSG': No such file or directory

adriangl commented 3 years ago

@nokite Could you provide some data about what OS you use and the Java version on your machine so I can try debugging this?

nokite commented 3 years ago

Sure, I'm using:

nokite commented 3 years ago

To summarize the suggested improvements:

For instance, I use ktlint in my project, and it also shows a lot of noise in the small window in Android Studio. However, the nice thing is that violations are normally shown on new lines at the end, so it's relatively easy to see them. We also have a way to run the check from command line, to show the violations in a full-screen window.