search

hyperdevs-team / poeditor-android-gradle-plugin

Gradle plug-in that enables importing PoEditor localized strings directly to an Android project
Apache License 2.0
51 stars 26 forks source link

Setting order is not working #61

Closed carlosrivin closed 1 year ago

carlosrivin commented 1 year ago

SW details (please complete the following information):

Summary and background of the bug In the documentation it's mentioned that it's possible to send order in the parameters but I belive in the latest gradle settings it's not working because it's missing a setter. Something like this for example: fun setDefaultLang(value: String) = defaultLang.set(value)

This is not available for order

Steps to reproduce Steps to reproduce the behavior:

  1. Add the "order = "terms"" in the poEditor block.
  2. Sync the project
  3. See error

A problem occurred evaluating project ':app'.

Could not set unknown property 'order' for extension 'poEditor' of type com.hyperdevs.poeditor.gradle.PoEditorPluginExtension.

Expected behavior Value would be set in the request to poeditor and terms would arrive ordered

Current behavior Crashes. Exception in pasted above.

Additional context Nothing else.

adriangl commented 1 year ago

Hi @carlosrivin!

Thanks for the report, I must have missed the setter creation when code reviewing the PR that introduced the parameter, sorry!

It should now be fixed in #62, please let me know if it works ;)

carlosrivin commented 1 year ago

the fix worked! :)

side question. Is there a way to send this options parameter so that I can request it without quotes? I find it odd this quotes default way.

Link about it: https://poeditor.com/kb/quotes-in-android-string-resources