search

hyperfiddle / rcf

RCF – a REPL-first, async test macro for Clojure/Script
MIT License
278 stars 12 forks source link

Calva user reports regression in reporter formatting related to newlines #66

Open dustingetz opened 2 years ago

dustingetz commented 2 years ago

Daniel Jomphe Here's a screenshot taken in May with Calva. Lines 942 and 969... It made REPL printing much faster - one line per success slows down things a lot in Calva.

image

2m Daniel Jomphe I tested the latest RCF releases with Calva. 20220405 (and earlier) prints them all on the same line 20220827-151056 prints each :white_check_mark: on a newline 20220902-130636 prints each :white_check_mark: on a newline

dustingetz commented 2 years ago

Reporters.cljs before April 5: https://github.com/hyperfiddle/rcf/blob/5b6d7443d8ba53eb4c44a30e24565c81d4aca91a/src/hyperfiddle/rcf/reporters.cljs#L19 First change after April 5: https://github.com/hyperfiddle/rcf/blob/2e41d98ee5bb9fab3a289cd34c71a54177540370/src/hyperfiddle/rcf/reporters.cljs#L15

ggeoffrey commented 2 years ago

I initially replied to Daniel that RCF always printed one ✅ per line in Calva. I was wrong.

The attached screenshot shows a CLJ REPL. We should look for a difference in reporters.clj, not .cljs.