search

hyperfiddle / rcf

RCF – a REPL-first, async test macro for Clojure/Script
MIT License
271 stars 11 forks source link

use the method toSymbol instead of using the attributes ns and sym #69

Closed mraveloarinjaka closed 1 year ago

mraveloarinjaka commented 1 year ago

The attribute ns only exists for clojure.lang.Var but not for sci.lang.Var. The method toSymbol can be used to create a symbol from a var and exists on clojure jvm and sci.

mraveloarinjaka commented 1 year ago

link to issue https://github.com/hyperfiddle/rcf/issues/35

borkdude commented 1 year ago

This PR should be preferred: https://github.com/hyperfiddle/rcf/pull/70 for bb compatibility

borkdude commented 1 year ago

@dustingetz This can be closed now

mraveloarinjaka commented 1 year ago

solved via 9ce258d75a87cd8c8d9ab6b5fa01f3ca37a29782

dustingetz commented 1 year ago

Thank you for the PR @mraveloarinjaka