hyperhq / hyperd

HyperContainer Daemon
http://www.hypercontainer.io
Apache License 2.0
1.98k stars 194 forks source link

Remove snapContainers and snapVolumes and use other way to handle the lock issue of XPod.updatePodInfo #729

Closed teawater closed 6 years ago

teawater commented 6 years ago

After taking a look at the code, I think the snap xxx is useless. So I remove snapxxx and add lock to the code that will write p.containers and p.volumes with p.statusLock.Lock().

gnawux commented 6 years ago

LGTM

looks reasonable. why didn't we do this before trying resource lock on info and the snap?