search

hyperhq / hypernetes

The multi-tenant Kubernetes distro
http://hypernetes.com
Apache License 2.0
540 stars 46 forks source link

Use RFC3339 for time parse #158

Closed resouer closed 7 years ago

resouer commented 7 years ago

hyperd now use RFC3339 for time parse everywhere, we need to keep consistency.

Will send a patch to private after this.

feiskyer commented 7 years ago

@resouer Any reference when hyperd changed this?

resouer commented 7 years ago

@feiskyer I believe it's after this commit: https://github.com/hyperhq/hyperd/commit/9f32482a9b283e50c5632258482311f9faf74016 , when created, err := utils.ParseTimeString(info.Created) is removed, and then no utils.ParseTimeString is used anymore.

feiskyer commented 7 years ago

@resouer Got it. LGTM. Could you fix ci first?

resouer commented 7 years ago

Yes, I'm looking into it