hyperhq / runv

Hypervisor-based Runtime for OCI
Apache License 2.0
828 stars 129 forks source link

launch containerd through "/proc/self/exe containerd" #362

Closed YaoZengzeng closed 7 years ago

YaoZengzeng commented 7 years ago

In cri-o, it use exec.Command(...) to launch runtime, it dosen't inherit PATH from parent process. For runv, it can't launch containerd because can't find runv in PATH. So use "/proc/self/exe" rather than "runv" to launch containerd.

laijs commented 7 years ago

L164: path, err := osext.Executable() L206: cmd.Path = path

Doesn't it work?