if the container's init process exit, clean up all other processes

hyperhq / runv

Hypervisor-based Runtime for OCI

Apache License 2.0

828 stars 129 forks source link

if the container's init process exit, clean up all other processes #374

Closed YaoZengzeng closed 7 years ago

YaoZengzeng commented 7 years ago

fix issue #373 Signed-off-by: Yao Zengzeng yaozengzeng@zju.edu.cn

laijs commented 7 years ago

what if the container's init process exits by itself? have you try docker of containerd in this case? we are following them.

wrouesnel commented 7 years ago

If the docker container's init exits, docker's behavior is to kill the rest of the container's processes.

I've been running with this patch for a while and it seems to work okay.

laijs commented 7 years ago

other processes will be killed in hyperstart(https://github.com/hyperhq/hyperstart/pull/96), the runv will receive the finished event, and cleanup the processes. Is this pr really needed?

laijs commented 7 years ago

the hyperstart does it