search

hyperhq / runv

Hypervisor-based Runtime for OCI
Apache License 2.0
828 stars 129 forks source link

Implement service with IPVS #409

Closed Crazykev closed 7 years ago

Crazykev commented 7 years ago

this PR is IPVS service workflow in runv.

Add two APIs to get and apply IPVS service from/to vm. When applying ipvs patch failed, will restore to original one.

Signed-off-by: Crazykev crazykev@zju.edu.cn

Crazykev commented 7 years ago

@laijs @feiskyer I've re-implement this with hyperstart-exec you mentioned before, and added a sync wrapper to hyperstart-exec, hope I'm not using it in a wrong way. If this is ok, I'll remove those useless code in hyperstart and re-vendor to hyperd.

Crazykev commented 7 years ago

@laijs Others have fixed.

gao-feng commented 7 years ago

Get/ApplyIPVSService api should in hyperd, it is not suitable for runv.

Crazykev commented 7 years ago

@gao-feng

it is not suitable for runv.

Agreed with you, I leave it here just because I'm not sure whether we should expose hyperstart-exec to hyperd, if it's fine, I will open a new pr to make this method public and move Get/ApplyIPVSService api to hyperd.

Crazykev commented 7 years ago

close this since implement have been move to #413 and https://github.com/hyperhq/hyperd/pull/494