search

hyperhq / runv

Hypervisor-based Runtime for OCI
Apache License 2.0
828 stars 129 forks source link

use APIVersion to wait for vm starting #422

Closed gao-feng closed 7 years ago

gao-feng commented 7 years ago

Change Launch function of vm as private function

Signed-off-by: Gao feng omarapazanadi@gmail.com

laijs commented 7 years ago

it is better to remove the waitStarted argument from GetVm(). the call sites who use waitStarted=true could use hyperstart API instead. (example: call the vm.GetHyperstartAPIVersion() instead). and some call sites who use waitStarted=true should be converted to who uses waitStarted=false.

alternative: call hyperstart API instead of WaitRespond in GetVm().

what do you think ?

gao-feng commented 7 years ago

Will update this

gao-feng commented 7 years ago

@laijs updated

laijs commented 7 years ago

LGTM