hyperhq / runv

Hypervisor-based Runtime for OCI
Apache License 2.0
828 stars 129 forks source link

[WIP]use fifo files in non-console io mode #483

Closed Crazykev closed 7 years ago

Crazykev commented 7 years ago

Ref: #481 The original design use current progress' stdio and pass them to containerd in create stage. This will lead to -d flag behave wired, since you've already passed stdin to container.

This PR enable two phase io connection use fifo pipes. In create stage, create three named fifo files as stdio passed to container. In start stage, open these three files and bind them with stand input/output using io.Copy()

/cc @laijs

Signed-off-by: Crazykev crazykev@zju.edu.cn

laijs commented 7 years ago

537 is merged, could you check if the problem is fixed please?