search

hyperhq / runv

Hypervisor-based Runtime for OCI
Apache License 2.0
828 stars 129 forks source link

Track container status, and add delete command to OCI interface #526

Closed tvelocity closed 7 years ago

tvelocity commented 7 years ago

This PR implements the delete command as defined by the OCI spec.

To properly separate the container stopped state, from a deleted (non existent state) we add the necessary container states to runv.

tvelocity commented 7 years ago

Currently looking into the failing tests.

WeiZhang555 commented 7 years ago

ping @laijs Can you take a look at this? ( @tvelocity is our guy from Europe :smile: )

gnawux commented 7 years ago

@tvelocity we merged #537 , which aimed to improve the compatibility with the latest containerd and changed the cli much. Could you help check/update this PR? Thank you very much.

laijs commented 7 years ago

@tvelocity runv cli is being improved continuously and had just been refactored at #537 . It seams that the changes in this pr is outdated.

Moreover, runv delete was also implemented in #537. Feel free to test it and give any possible feedback.

However, runv list & runv state are changed less, and the 'container status' shown by these two commands is still always "running". Could you create new PR for it please if any possible? And this one is closed.

Thank you for your contribution.