hyperhq / runv

Hypervisor-based Runtime for OCI
Apache License 2.0
828 stars 129 forks source link

return cleanly when return non-zero #590

Closed laijs closed 7 years ago

laijs commented 7 years ago

remove the incorrectly appended "":

runv exec test_busybox command-does-not-exist exec failed: No such file or directory

Signed-off-by: Lai Jiangshan
bergwolf commented 7 years ago

Should we fix osProcessWait() instead? e.g., make sure it always sets err if exit status is non-zero.

laijs commented 7 years ago

non-zero exitcode returns from the process doesn't mean error.

laijs commented 7 years ago

@bergwolf updated

bergwolf commented 7 years ago

/lgtm!