hyperhq / runv

Hypervisor-based Runtime for OCI
Apache License 2.0
826 stars 129 forks source link

refactor codes in xen to be more readable #602

Closed allencloud closed 7 years ago

allencloud commented 7 years ago

I found that we could simplify some codes in xen.go. Almost I used return fast to eliminate an else, and this will make codes ident less.

In addition, I think this PR also fixes an improper place, see code review comment from mine.

Signed-off-by: Allen Sun shlallen1990@gmail.com

gao-feng commented 7 years ago

LGTM, can you rebase this pr? there is a conflict in hypervisor/xen/xen.go.

Thanks!

allencloud commented 7 years ago

Updated that, PTAL. @gao-feng

allencloud commented 7 years ago

Seems the IDE misleads me to correct the code. Updated again. PTAL @gao-feng

gao-feng commented 7 years ago

merge, thanks!