search

hyperhyperspace / hyperhyperspace-core

A library to create p2p applications, using the browser as a full peer.
https://www.hyperhyperspace.org
MIT License
196 stars 12 forks source link

WIP: simplify and speed up build process #4

Closed sbillig closed 3 years ago

sbillig commented 3 years ago

I haven't tried using this in p2p-chat yet to make sure it works, or messed with the build setup of any other repos yet.

Note that the 'build-examples', 'example-chat', etc npm scripts are gone. I'd be in favor of removing the examples from this repo, and adding a note to the readme pointing elsewhere. 'chat' is redundant with p2p-chat, and I think simple examples would be more be more useful in a separate repo where they use hhs-core in the way a normal project would (list it as a dependency and import { ... } from '@hyper-hyper-space/core'). Or maybe there's a way to achieve that while keeping them in this repo?

sbazerque commented 3 years ago

This is amazing!

p2p-chat, p2p-chat-cli and p2p-web all work with minimal changes that I'll commit in a second.

Agreed about moving the examples somewhere else, I'd expect p2p-chat to grow in complexity to support fully featured chat rooms, so I believe there's still a need for a simple chat example somewhere. Probably an "examples" repo?