hyperion-3360 / 2024-crescendo

main repo for the 2024 FRC code
Other
0 stars 0 forks source link

removed waits and adding a max speed checker to fix led delay #32

Open Igor-Volkov3360 opened 7 months ago

Igor-Volkov3360 commented 7 months ago

deleted the wait command in the shoot sequence because the command will execute and then do the next command no need to have a wait command in here also added a boolean method in shooter that checks if the motors reached max speed this is used in the elevating sequence to signal the exact moment when the motors are at max speed and not use an arbitrary wait command

Igor-Volkov3360 commented 7 months ago

closed until tested and prepared for unforeseen consequences...

Igor-Volkov3360 commented 7 months ago

added a wait until command so the led state doesn't depend on the execution time of the hook but on if the note is out of the shooter we should be able to safely merge but then again this change isn't tested and isn't high priority at all in fact it is the lowest priority of them all review at convenience