hyperion-project / hyperion.ng

The successor to Hyperion aka Hyperion Next Generation
https://hyperion-project.org/
MIT License
3.03k stars 377 forks source link

No black borders on AMLogic platform input #1030

Closed V10lator closed 3 years ago

V10lator commented 3 years ago

Bug report

It seems the image is grabbed before black borders (or Kodi UI elements but that's probably a different issue) are added, then resized to whatever size is setted in the config. So one can't disable black border detection and if they are there the LEDs are off cause stretched on one axis.

Steps to reproduce

1) Disable black border detection 2) play a 4:3 video on a 16:9 screen or vice-versa

What is expected?

LEDs at the black borders stay off.

What is actually happening?

Hyperion is ignoring the black border.

System

Hyperion Server:

Hyperion Server OS:

jasimancas commented 3 years ago

Same error here with Hyperion 2.0.0-alpha.9

Paulchen-Panther commented 3 years ago

@Portisch Can you say something about that?

Portisch commented 3 years ago

A bit late but I tested it now. On CoreELEC 19.2_Matrix-rc2 and alpha.9

I think it's a issue of the grabber as it get stretched in the Webinterface: Screenshot-2021-06-15-22-11-38-736-com-android-chrome

IMG-20210615-221305

Lord-Grey commented 3 years ago

@V10lator Can you re-test with alpha10 and report back please, if the issue is still present?

V10lator commented 3 years ago

It's still the same with alpha10.

V10lator commented 3 years ago

Made a photo showing the issue. This is with black border detection disabled: IMG_20210807_213739

Paulchen-Panther commented 3 years ago

Actually, this issue belongs in the feature request corner. Since the AMLogic grabber captures the video source material and not the screen, no black borders can be detected because there are none. If the video source material is encoded with black borders, everything should work as intended. I see that the next thing is that black border detection does not work with AML grabber and 16:9 videos on 4:3 output devices. I will close here. Please make a feature request. Thanks