hyperion-project / hyperion.ng

The successor to Hyperion aka Hyperion Next Generation
https://hyperion-project.org/
MIT License
2.95k stars 371 forks source link

Re-add Temperture adjustment #1710

Open Lord-Grey opened 4 months ago

Lord-Grey commented 4 months ago

Summary

What kind of change does this PR introduce? (check at least one)

If changing the UI of web configuration, please provide the before/after screenshot:

image

Does this PR introduce a breaking change? (check one)

If yes, please describe the impact and migration path for existing setups:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

PLEASE DON'T FORGET TO ADD YOUR CHANGES TO CHANGELOG.MD

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information: Fixes #658 Fixes #1410

Rastafabisch commented 3 months ago

I've got a further suggestion: Automatically apply such temperature adjustments based on the OS night mode filter. This would apply to any desktop OS like Linux' Gnome, KDE, Windows 10 & 11 and macOS since Sierra (10.12).

Lord-Grey commented 3 months ago

@kopidoo Maybe you could check, if this PR addresses the issue #1410 you raised before. @Rastafabisch Before we discuss features on top of this feature, would you mind testing, if it works in general?

You could test the PR on without building yourself, following the Testing Pull Requests documentation.