search

hyperion-project / hyperion.ng

The successor to Hyperion aka Hyperion Next Generation
https://hyperion-project.org/
MIT License
3.04k stars 377 forks source link

Problems with Lightberry APA102 and the new Device merge #332

Closed janpfischer closed 7 years ago

janpfischer commented 7 years ago

As some people of you already know I have problems with my Lightberry Setup and hyperion.ng. On hyperion everything is fine.

The problem is: At 3/4 of the in hyperion.ng defined LEDs one LED will flicker red and the led after that is purple. After that everything is black. Firstly I searched at the Lightberry Sketch without success. Then I noticed when I turned off the new "lightberry mode" which came with PR303 all LEDs are turning on again. (Not right color and more than defined but they turn on atleast)

So I checked out PR302 with the old adalightapa102 device before the merge, compiled it and everything works fine again like in hyperion (without .ng)

So I think there is a problem in the merge (PR303) in the part for "lightberry mode".

303

redPanther commented 7 years ago

I'm on it. It's a merge problem. Did you use this sketch? https://github.com/hyperion-project/hyperion.ng/blob/master/assets/firmware/arduino/adalightapa102/LightberryHDUSBAPA1021.1.ino

janpfischer commented 7 years ago

Nice, thank you!

At the moment I only tested with the newest from http://update.lightberry.eu I can test the other as well.

Here is a diff between those: (left is sketch from hyperion git / right is from update.lightberry.eu) https://www.diffnow.com/?report=6t87g

Can you say which should be used?

redPanther commented 7 years ago

stupid thing ... adalight device was never in lightberry mode, because config parameter was evaluated after init. shoud be fixed now

janpfischer commented 7 years ago

It is working. :)

Thank you so much for the very fast fix!