search

hyperion-rt / hyperion

Hyperion Radiative Transfer Code
http://www.hyperion-rt.org
BSD 2-Clause "Simplified" License
52 stars 26 forks source link

Fix continuous integration #230

Closed astrofrog closed 1 year ago

astrofrog commented 2 years ago

Work in progress!

astrofrog commented 1 year ago

Looks like the difference is due to changes in the source positions:

position        y of </Sources/source_03567> y of </Sources/source_03567> difference          
------------------------------------------------------------
                -9.0529         -9.0529         1.77636e-15

In some cases. We could also try and make the source names more reproducible to minimize diffs between HDF5 files but that's less important. So need to figure out why in e.g. test_ptsource_vertices_noclip the source positions are changing.

astrofrog commented 1 year ago

The numerical differences appear to be due to https://github.com/numpy/numpy/pull/19478

astrofrog commented 1 year ago

Possible fix would be to use:

            export NPY_DISABLE_CPU_FEATURES=AVX512_SKX

but need to check how we would force Numpy to install from source.