search

hyperion-rt / hyperion

Hyperion Radiative Transfer Code
http://www.hyperion-rt.org
BSD 2-Clause "Simplified" License
52 stars 26 forks source link

Tentative fix for issue #89. #90

Closed bluescarni closed 10 years ago

bluescarni commented 10 years ago

See #89.

Try to be more generic in the configure script when checking for funky gfortran compiler names.

@astrofrog Can we assume sed is available on all supported platforms? Could you check on OSX please? :)

Also, not sure it is necessary to change the configure script, as it is generated from the .ac. But since it is included in the repo I thought I would change it as well.

astrofrog commented 10 years ago

@bluescarni - thanks! We can assume sed exists on all platforms. You should not edit the configure script directly, but you can update it with:

autoconf configure.ac > configure

then commit the changes. I think it will add the comments that you had added in configure.ac.

bluescarni commented 10 years ago

@astrofrog: I did indeed edit configure.ac and then regenerated the configure script, I was just wondering if the configure script belongs to the repo since it gets generated from the source .ac (though I am not an autotools expert, not sure what the best practice is so feel free to ignore me :).

astrofrog commented 10 years ago

@bluescarni - ah yes, the configure script does belong here for now, since I don't want to assume that people have autotools installed. We could make it something that happens during the making of the source distribution, but enough people use it directly from the git repo that this is the easiest way to do it.