Closed nhaydel closed 1 year ago
@nhaydel could you do a rebase please :)
@nhaydel Looks good! just rebase, fix that test and add some more and run go fmt! Thank you dude !
LGTM as soon as what @hyperioxx has suggested has been actioned 🔥
Thanks for the quick review! Rebase seems to have fixed that test. I'll format and add tests probably tomorrow
Thanks for the quick review! Rebase seems to have fixed that test. I'll format and add tests probably tomorrow
thats always handy 🤣👌🏻
Sorry for all of the commits. I've formatted and written tests. Also update the mongo service registry in the same way the yaml and redis registries were updated. Should be ready for final review
@nhaydel Awesome work dude !!!!!!
Still need to add tests and documentation, but I wanted to get my thoughts out there:
This PR adds configurable JWT validation per backend specified in services.yaml or redis. Backend service config now takes the following options for specifying auth requirements:
This auth config is optional. If not provided, requests will be forwarded normally. Steps to test:
Add an auth config to one or more of your services in your services.yaml file. Ex:
Get a token from the auth server specified in the auth config
Run frontman and the backend(s) to test against
Make a request through frontman with and without the appropriate token.