search

hyperium / h2

HTTP 2.0 client & server implementation for Rust.
MIT License
1.34k stars 269 forks source link

Requests should not be provided to user if stream has been reset #30

Open carllerche opened 7 years ago

carllerche commented 7 years ago

For example, the server receives a request, then an invalid sequence of window updates. The stream is then reset. In this case, the server app should never see the request.

seanmonstar commented 6 years ago

Should this actually be done at this level? You could imagine a request with useful info sent, but the client doesn't want the response at all, and so sends a cancel after the headers. In this case, the app never knows what data was sent.

Even if the stream was reset for another reason, the app may still want to be able to log that.

carllerche commented 6 years ago

Maybe... it seems OK to punt this question until later. It is not a breaking change either way I would say.

nox commented 3 years ago

This issue is kinda at odds with #536. I feel like the user of the h2 crate should see as much as possible of the data that was send to it, as long as it isn't at odds with respecting the semantics of the protocol.

Should we close this?