search

hyperium / h2

HTTP 2.0 client & server implementation for Rust.
MIT License
1.35k stars 270 forks source link

Implement server::Builder::max_send_buffer_size #577

Closed nox closed 2 years ago

nox commented 2 years ago

I tried using wait_for_capacity to write a test but I couldn't understand how to use it in conjunction with .drive on the server side.

nox commented 2 years ago

@seanmonstar Do you think h2 should have a default maximum?

nox commented 2 years ago

Also, do you have any idea how I could write a test for this?

seanmonstar commented 2 years ago

Do you think h2 should have a default maximum?

Hm, probably yes.

Also, it might be good (once we have it working) to compare how this change affects hyper's http2 end_to_end benchmarks, just so we know.