search

hyperium / h2

HTTP 2.0 client & server implementation for Rust.
MIT License
1.34k stars 269 forks source link

chore: update indexmap dependency requirements to ^1.5.2 #591

Closed o0Ignition0o closed 2 years ago

o0Ignition0o commented 2 years ago

Indexmap released versions 1.6 and 1.7, which are relied on in other crates.

This unfortunately means relying on Hyper as well as other crates which depend on 1.6 and above will fail dependency resolution.

Relaxing the requirement here would allow resolution to find more compatible ranges, while maintaining compatibility according to semver.

How do you feel about this?

Thanks! :)

sfackler commented 2 years ago

This unfortunately means relying on Hyper as well as other crates which depend on 1.6 and above will fail dependency resolution.

indexmap = "1.5.2" is equivalent to indexmap = ">= 1.5.2, < 2.0.0". It will absolutely resolve to a 1.6.x release. What is the specific resolution failure you are seeing?

o0Ignition0o commented 2 years ago

Hmm it looks like I missread indeed, maybe i forgot to run cargo update after my dependency bump.

Closing this thank you (sorry) for (wasting) your time!