search

hyperium / h2

HTTP 2.0 client & server implementation for Rust.
MIT License
1.34k stars 269 forks source link

Upgrade tokio-util to 0.7 #603

Closed djc closed 2 years ago

olix0r commented 2 years ago

I'm not sure why the nightly build failed but it looks like it's picking up a very old tokio version:

Compiling tokio v1.0.1
djc commented 2 years ago

That's because it's the cargo update -Zminimal-versions step of the CI build. I already asked on the Tokio Discord about this, we should likely get a new tokio-util that fixes the minimal version of Tokio that it needs.

olix0r commented 2 years ago

We could probably unblock this by specifying the minimum working version in h2's Cargo.toml:

https://github.com/hyperium/h2/blob/4c31a320beb01584b55cfcb44b96c0f151324af6/Cargo.toml#L47

djc commented 2 years ago

I submitted https://github.com/tokio-rs/tokio/pull/4521 to try and get a tokio-util 0.7.1 out.

djc commented 2 years ago

@paolobarbolini thanks for the reminder! I think this could be merged now.

paolobarbolini commented 2 years ago

Could we get a new release with this @seanmonstar? I'd love not having to live with duplicate dependency versions in my dependency tree

seanmonstar commented 2 years ago

Published: https://github.com/hyperium/h2/releases/tag/v0.3.13