Open arthurlm opened 2 years ago
@seanmonstar do you see any issue with this change?
Any update on this one? Just met the same problem when communicate with k8s via tonic :(
Any update on this? Would be good to stop using a fork :)
Any update on this one? Just met the same problem when communicate with k8s via tonic :(
k8s 1.26 kubelet sets localhost
authority for device-plugin and CSI.
Even if recent version of k8s set localhost
for :authority
field:
h2
still does not respect HTTP2 RFC without this changeI do not really understand why maintainers do not want to review / merge / close this PR. I guess it is probably dues to some lack of time or PR visibility / interest.
I still hope this will be merged or discussed one day 😄. So this is why I have not closed this for now...
@arthurlm FWIW I agree with you. Just wanted to share what I know k8s kubelets can do today.
Looking at RFCs:
So, from my understanding:
Following (1):
:authority
field is not mandatory in HTTP2.Following (2):
/
character is not expected for regular authority).:authority
. It should be treated as opaque string.Following (3):
:authority
field should be a valid host and port in the case ofCONNECT
method.NOTE 1: I have not read the whole RFCs but just read in details the mentioned sections. If anyone have better understanding of this RFCs, please feel free to comment / edit this PR :wink: !
NOTE 2: Please have a look at my first comment about k8s usage with
tonic
for more details.This change could fix a lot of already referenced issues / PRs using
h2
and gRPC /tonic
.It will also:
tonic
(which is not possible for now without forkingh2
)h2
to better fit to HTTP2 RFC specification :grin: