Closed djkoloski closed 1 year ago
https://github.com/hyperium/h2/pull/616 should fix the nightly CI.
(though we can't do anything with them).
Is this beneficial somehow? I'd love to understand the goal.
Sorry, I didn't put enough context in here. https://github.com/hyperium/hyper/pull/2830 contains some work to remove a transmute from hyper. Rather than write new Buf
impls with unreachable!
, I figured we could clean things up bit by relaxing the bounds in h2
. That way we don't have to write uncallable Buf
impls with impossible methods. It's not very important, but it does help with code quality downstream.
Bumping this after #616 was merged.
Quick bump on this, if there are no objections I think this would be a good improvement. 🙂
Oh sorry, we can get this merged :D
This bound is only necessary when calling methods on
SendStream
because we don't use any associated types ofB
'sBuf
impl in the type. Relaxing this bound allows us to constructSendStream
s with non-Buf
B
(though we can't do anything with them).