search

hyperium / h2

HTTP 2.0 client & server implementation for Rust.
MIT License
1.34k stars 269 forks source link

Fix all clippy warnings #652

Closed gtsiam closed 1 year ago

gtsiam commented 1 year ago

Fixes all clippy warnings.

Split from #649.

gtsiam commented 1 year ago

Also while I'm at it: Would you like me to add a style check to the ci so there's no need to do this kind of large pr again?

LucioFranco commented 1 year ago

Also while I'm at it: Would you like me to add a style check to the ci so there's no need to do this kind of large pr again?

You mean run clippy in ci? I personally don't like it since it adds a lot of noise.

gtsiam commented 1 year ago

You mean run clippy in ci? I personally don't like it since it adds a lot of noise.

Yes. Though I really wouldn't call clippy warnings "noise". With the exception of the manual_range_contains lint, most of the changes in this pr should never have needed to be done in mass. Catching them earlier would be much easier for all involved.

But I'm not gonna push for it. You're the maintainer. If you don't want it, you don't want it and that's the end of that.

gtsiam commented 1 year ago

Ok, everything should be resolved now