search

hyperium / h2

HTTP 2.0 client & server implementation for Rust.
MIT License
1.34k stars 269 forks source link

server: Ignore `NotConnected` errors on shutdown #654

Closed LucioFranco closed 1 year ago

LucioFranco commented 1 year ago

Related to https://github.com/hyperium/tonic/issues/1183

I started to see this error come up when debugging the above tonic issue, to me ignoring this error seems okay in this context, but I'd like to have some other eyes on it.

cc @seanmonstar @hawkw

seanmonstar commented 1 year ago

I'm not so sure we should choose to ignore the error. We don't know the full context of the IO transport. It feels more correct to me to pass that error along to the user, and they can decide if to ignore it or not.

flumm commented 1 year ago

seems to be more or less the same changes i proposed in #653

LucioFranco commented 1 year ago

I'm not so sure we should choose to ignore the error. We don't know the full context of the IO transport. It feels more correct to me to pass that error along to the user, and they can decide if to ignore it or not.

Sounds good to me