Add Protocol extension to Request on Extended CONNECT

hyperium / h2

HTTP 2.0 client & server implementation for Rust.

MIT License

1.34k stars 269 forks source link

Add Protocol extension to Request on Extended CONNECT #655

Closed cloneable closed 1 year ago

cloneable commented 1 year ago

This exposes the :protocol pseudo header as Request extension.

Fixes #347

cloneable commented 1 year ago

@nox, have you had a chance to look at this?

cloneable commented 1 year ago

@seanmonstar, looks like @nox hasn't been active for months now. Can you recommend another reviewer? Btw, how does the following even work in hyper without this PR? https://github.com/hyperium/hyper/blob/5bf16402f7a146417a9f997387401f9dc5a7d63d/src/proto/h2/server.rs#L291-L293

seanmonstar commented 1 year ago

how does the following even work in hyper without this PR?

Hm, well, the code itself is just conditional, if the extension exists, replace it with another. So it never fails. But I imagine we don't have a test anywhere that it ever succeeds, either. Would be worth making one, I think. I'll review this shortly.