search

hyperium / h2

HTTP 2.0 client & server implementation for Rust.
MIT License
1.38k stars 279 forks source link

tone down all debug to trace #820

Open lthiery opened 1 day ago

lthiery commented 1 day ago

Some logging frameworks don't really tolerate module level configurations well. I have quite a broad project but h2 seems to be the only dependency that has such chatty debug settings.

Would you be open-minded to removing all debug! in favor of trace!?

seanmonstar commented 1 day ago

This library already has a lot of noise at the trace level, the things at debug level are indeed helpful for many people to debug without needing the full firehose.

I don't think the solution is to reduce the helpfulness of the logs for those people, but to use a logger that allows you to adjust specific libraries if you don't want their logs.

lthiery commented 1 day ago

I'm still trying to fix that but this is also the only crate that's causing so much chattiness. Perhaps if just the "send" in frame_write and "read" in frame_read could be downgraded?