simplify traits - Githubissues

hyperium / h3

MIT License

575 stars 75 forks source link

simplify traits #200

Open Ruben2424 opened 1 year ago

Ruben2424 commented 1 year ago

This is a not 100% working change to explore some of the proposed changes from #177.

Ruben2424 commented 1 year ago

Thanks for the review.

I would recommend the enum proposal from https://github.com/hyperium/h3/issues/177 B2 (replace Error with Close enum).

I will continue to work on this and implement #177 B2.

I Think this are my next tasks:

[x] Fix the failing tests
[ ] Implement #177 B2
[ ] Make WebTransport work with all the changes
[ ] Make sure everything is well Documented
[ ] fix paths to binary

dongcarl commented 11 months ago

@Ruben2424 Is this PR in a state where it's ready for review?

Ruben2424 commented 11 months ago

@Ruben2424 Is this PR in a state where it's ready for review?

@dongcarl you can review the changes if you want. But there is still some work left to improve the error types. I probably have time to continue on this next week.

Ruben2424 commented 1 month ago

I think i will not continue on this as one big pr. Instead I probably will split them up into multiple smaller ones which are easier to review.