search

hyperium / h3

MIT License
595 stars 76 forks source link

Initial support for RFC 9298 "Proxying UDP in HTTP" #203

Closed dongcarl closed 1 year ago

dongcarl commented 1 year ago
  1. Add support for RFC 9298 in :protocol extension

  2. bugfix: Properly encode :protocol header

    Previously, the `:protocol` header wouldn't be set when the `Protocol`
extension was active for a `Request`.

This was most likely because the Webtransport PR (the PR that introduced
the `Protocol` extension) did not include a client implementation and
thus did not test this.
dongcarl commented 1 year ago

@ten3roberts You might be interested in reviewing this 😬

ten3roberts commented 1 year ago

Looks interesting, though I am unfortunately not a collaborator on this repository so I don't think I can submit a review.

But yes, you are indeed correct, the missing serialization of the protocol extension header is just an oversight as the Webtransport PR was only for the server due to PR size and usage requests.