Closed dongcarl closed 12 months ago
@Ruben2424 Resolved!
Perhaps one thing to discuss is whether or not to include the Deref
and DerefMut
impls here: https://github.com/hyperium/h3/pull/208/files#diff-4fc440b791f25fbde8061757f9ecfdcb61af28bc20a5b3c236f0ae1f6c96db4eR181-R194
https://doc.rust-lang.org/std/ops/trait.Deref.html says that: "Deref should only be implemented for smart pointers"
@Ruben2424 Removed!
The
Settings
struct is an abstract representation offrame::Settings
.Basically:
When talking about our own connection, we should use
Config
.ConnectionInner
'sconfig
fieldWhen talking about a peer's settings, we should use `Settings.
SharedState
'speer_config
fieldThis separation allows us to define some conversions:
Config
->frame::Settings
ConnectionInner::new
&frame::Settings
->Settings
ConnectionInner::poll_control