hyperium / h3

MIT License
575 stars 75 forks source link

Split out a `Settings` struct from `Config` #208

Closed dongcarl closed 12 months ago

dongcarl commented 1 year ago

The Settings struct is an abstract representation of frame::Settings.

Basically:

This separation allows us to define some conversions:

dongcarl commented 12 months ago

@Ruben2424 Resolved!

dongcarl commented 12 months ago

Perhaps one thing to discuss is whether or not to include the Deref and DerefMut impls here: https://github.com/hyperium/h3/pull/208/files#diff-4fc440b791f25fbde8061757f9ecfdcb61af28bc20a5b3c236f0ae1f6c96db4eR181-R194

https://doc.rust-lang.org/std/ops/trait.Deref.html says that: "Deref should only be implemented for smart pointers"

dongcarl commented 12 months ago

@Ruben2424 Removed!