search

hyperium / h3

MIT License
575 stars 75 forks source link

do not explicit copy data before sending #234

Open Ruben2424 opened 3 months ago

Ruben2424 commented 3 months ago

I am not sure if this is the best way to write this or if it gains performance. I am happy to get Feedback.

seanmonstar commented 3 months ago

Good idea! Do things have to be Send? If we don't need it, people can choose to use single threaded types.

Ruben2424 commented 3 months ago

Good idea! Do things have to be Send? If we don't need it, people can choose to use single threaded types.

@seanmonstar I think they have to be Send because data is moved into the ReusableBoxFuture. Maybe i could bring back the old implementation where B: !Send?

Ruben2424 commented 3 months ago

Maybe i could bring back the old implementation where B: !Send?

Ok i think this is not possible.