Closed djc closed 1 month ago
i probably can take a look at the tests this weekend
The same error used to happen in particularly macOS a lot.
Yeah, I was testing on macOS.
I fixed some race conditions in the failing tests. Does control_close_send_error
now work on macOS?
The test tests::connection::client_close_only_on_last_sender_drop
still fails. I couldn't fix it without understanding what exactly it tests.
Does it test anything? Can we remove it?
Yes, I only have client_close_only_on_last_sender_drop
failing now.
I squashed some intermediate commits and switched to the published versions of Quinn crates.
The test
tests::connection::client_close_only_on_last_sender_drop
still fails. I couldn't fix it without understanding what exactly it tests. Does it test anything? Can we remove it?
@seanmonstar are you the person who has more context on this?
I'm not entirely sure, git blame says it was added in https://github.com/hyperium/h3/commit/64bea294977716774ac2800d1a26a71149ad4398.
One option is to comment it out with a note, and if we notice something wrong related to closure, then we can try to figure out what this one was checking specifically.
One option is to comment it out with a note, and if we notice something wrong related to closure, then we can try to figure out what this one was checking specifically.
I think the failure has nothing todo with the purpose of this test. It is also a race condition. The client future finishes so fast, that the server cannot initialize the connection fully before the client closes the connection.
Then this unwrap()
panics let mut incoming = server::Connection::new(conn).await.unwrap();
.
We could also do a recv_response().await
on the client request streams. But for me it seams that maybe they were intentionally omitted? idk?
@seanmonstar friendly ping? This is blocking upgrading hickory-dns to latest rustls/quinn etc, so would be nice to get it released.
I don't have anything else. You could comment out the test, or explore what Ruben said.
I can try to finnish the test (or comment it out) this weekend. After a review i can prepare releases.
@Ruben2424 thanks!
The tests are now successful. @seanmonstar do you mind doing a review?
Thanks for the reviews/fixes, looking forward to the release!
This is still failing some tests -- would appreciate some help with addressing these.
control_close_send_error
fails for me on master, too.We plan to release 0.11 soon, see https://github.com/quinn-rs/quinn/issues/1737.