search

hyperium / http

Rust HTTP types
Apache License 2.0
1.16k stars 291 forks source link

Allow nightly build to fail #389

Closed upsuper closed 4 years ago

upsuper commented 4 years ago

It's a common practice to allow failures in nightly for CI, as nightly is changing in a faster pace than most other projects, and it would be painful that you need to fix something whenever you want to change something.

This is especially a problem given that this project has #[deny(warnings)] which can be even more fluid.

seanmonstar commented 4 years ago

I think it's preferable to keep the nightly failure, so that way we know if there's a bug in nightly. In case where I've allowed this failure, I often don't notice until nightly is promoted to beta.

carllerche commented 4 years ago

I preference is to pin nightly to a specific version and to periodically increment it.

I would say either pin nightly or remove the nightly build. :-1: on allowing to fail.