search

hyperium / http

Rust HTTP types
Apache License 2.0
1.16k stars 291 forks source link

Reduce or eliminate unsafe code #398

Closed DemiMarie closed 4 years ago

DemiMarie commented 4 years ago

Last I checked, this crate used a lot of unsafe code, including a bespoke HashMap. This unsafe code should be eliminated, or at least greatly reduced and audited.

ghost commented 4 years ago

Unsafe code is not bad if you know what you're doing.

LucioFranco commented 4 years ago

I believe most of our unsafe code has been vetted. I think its unlikely we will remove it unless someone is willing to put the time into finding a suitable solution that performs just as well.

That said, I would really like to see more miri tests and using other tools to check our unsafe code. We are very happy to fix any issues found :)

carllerche commented 4 years ago

We would be happy to accept PRs that remove unsafe code while maintaining the feature set and performance :+1: