search

hyperium / http

Rust HTTP types
Apache License 2.0
1.12k stars 283 forks source link

chore: Update msrv to 1.56 #576

Closed LucioFranco closed 1 year ago

LucioFranco commented 1 year ago

@seanmonstar I think we just need to remove the requirement for the 1.49 test and change it to 1.56

seanmonstar commented 1 year ago

I think we just need to remove the requirement for the 1.49 test and change it to 1.56

What do you mean? Do you mean change the MSRV CI job to only do cargo build instead of cargo test?

LucioFranco commented 1 year ago

No I mean on github actions if you look below its waiting for a required 1.49 test which is no longer 1.49 but 1.56. This needs to be changed in branch protection settings.

seanmonstar commented 1 year ago

Oh. Would what I mentioned be true, though? The crate itself still builds on 1.49, it's just some test dependencies?

LucioFranco commented 1 year ago

Oh sorry yes, I mean I guess I could break out the benches and ONLY test the crate with MSRV is that preferred? I can make that change tomorrow.

hawkw commented 1 year ago

If 1.56.0 is only required for benches, it definitely seems preferable to continue supporting 1.49.0 unless we actually want to use features from 1.56.0 in the crate itself?