search

hyperium / http

Rust HTTP types
Apache License 2.0
1.12k stars 283 forks source link

Add HeaderMap collect from array #578

Closed light4 closed 1 year ago

light4 commented 1 year ago

Act like std::collections::HashMap from std from 1.56.0

tu6ge commented 1 year ago

Such a coincidence, I am creating PR #581 .

seanmonstar commented 1 year ago

Thanks for the PR! However, I don't think having this sugar in the library is what we want. There is the existing FromIterator implementation that helps with this.

light4 commented 1 year ago

This PR makes it more consistent with rust std. Maybe take another look at https://github.com/rust-lang/rust/pull/84111