search

hyperium / http

Rust HTTP types
Apache License 2.0
1.15k stars 285 forks source link

simplified code #694

Open wandercn opened 5 months ago

wandercn commented 5 months ago

remove generic T

tesaguri commented 5 months ago

This is a breaking change and I don't think it is going to be accepted, although I'm not the maintainer of the project.

Alternatively, you could add a default type to the T parameter, which is a non-breaking change, but in that case, the default parameter wouldn't be able to &str because that would require a lifetime parameter, and String wouldn't be appropriate as the default type for many use cases either due to a performance reason.

So, what is your motivation behind the change? If you just don't want to write type parameters in your code, you can define a type alias like type Port = http::uri::Port<String>; in your code.