search

hyperium / hyper

An HTTP library for Rust
https://hyper.rs
MIT License
14.58k stars 1.6k forks source link

Port Client connect/pool tests to hyper-util #2942

Open seanmonstar opened 2 years ago

seanmonstar commented 2 years ago

The integration tests checking the Connector and Pool parts of Client should be ported to the hyper-util crate. Not necessarily copy and paste, but that each logical case is tested. They were here in 0.14.x.

Michael-J-Ward commented 1 year ago

Hi Sean,

My understanding from the docs is that this Pool will serve a replacement for the old Client, per the roadmap.

https://github.com/hyperium/hyper/blob/984760f76aaf5f0e20dddd119cad8188ca81e0e4/docs/ROADMAP.md?plain=1#L296-L307 #

Following in the tower discord channel, it looks like you may be experimenting with the impl Service<Req> for Pool<T>, and I think that implementation blocks this test-porting. Is that correct?

PS: Sorry if I goaded you into closing this issue too early.