search

hyperium / hyper

An HTTP library for Rust
https://hyper.rs
MIT License
14.4k stars 1.59k forks source link

Add limited clippy to CI #2977

Open seanmonstar opened 2 years ago

seanmonstar commented 2 years ago

Add a new job to CI, clippy, but that is extremely limited in what lints it checks for. Clippy's defaults are usually too annoying, but there a few specific things that I would like to catch in an automated fashion:

Add the job as a needs dependency of the ci-pass top-level job.

mastrzyz commented 2 years ago

Taking a look on this!

dswij commented 2 years ago

Clippy's defaults are usually too annoying

@seanmonstar that's unfortunate to hear. Is there a specific lint that comes to mind, or is it the false positives in general?

tomkarw commented 2 years ago

I was surprised to see hyper not utilizing clippy to it's fullest. I usually run projects with pedantic enabled, and it has been nothing but valuable to me.

I already saw hyper-utils having some clippy warnings, maybe it would be easier there, to keep it strict from the get-go?