search

hyperium / hyper

An HTTP library for Rust
https://hyper.rs
MIT License
14.07k stars 1.55k forks source link

Make Future implementation on Connection unconditional on executor being Send + Sync. #3682

Open mstyura opened 3 weeks ago

mstyura commented 3 weeks ago

This PR is created to raise the question if Future implementation on Connection is mandatory to request Executor to be Send + Sync. Question initially raised here https://discord.com/channels/500028886025895936/670880858630258689/1247563996068970557.

mstyura commented 2 weeks ago

Interesting, CI does rustfmt --edition 2021 $(git ls-files '*.rs') and it formats code, while cargo fmt does not.

seanmonstar commented 1 day ago

I think this looks good, any reason it was marked a draft?

mstyura commented 1 day ago

It was initially supposed to raise a question, that's why I've marked it as draft. But as long as you are ok with changes I will unmask as draft and fix issues if any according to review