search

hyperium / hyper

An HTTP library for Rust
https://hyper.rs
MIT License
14.42k stars 1.59k forks source link

No `Connection: close` on HTTP1 Connection Drain #3720

Open Clendenin opened 1 month ago

Clendenin commented 1 month ago

When HTTP1 connection draining is activated, the Connection: close header is not attached to responses sent to active connections. This prevents active clients from realizing that the server is requesting that the connection be closed and prevents graceful draining of HTTP1 connections.

seanmonstar commented 1 month ago

Thanks for the report! I could have sworn we did this, but then tweaked the test and you're right, not done. PR is up at #3725.

Clendenin commented 1 week ago

Thank you @seanmonstar!

Catwoman08 commented 1 week ago

Reopened this until the PR #3725 gets merged.