Version 0.9 introduced max message size which is a breaking change

hyperium / tonic

A native gRPC client & server implementation with async/await support.

https://docs.rs/tonic

MIT License

10.02k stars 1.02k forks source link

Version 0.9 introduced max message size which is a breaking change #1431

Open Yifeng-Sigma opened 1 year ago

Yifeng-Sigma commented 1 year ago

https://github.com/hyperium/tonic/pull/1274 This is a breaking change, is there a way to make this more noticeable? In my application, previously the message size is 10mb, and upgrade broke things.

LucioFranco commented 1 year ago

Going from 0.8 to 0.9 is a breaking release so it was correct to release it like that. As for making it more noticeable that is a good question, since this is a DDOS prevention mechanism I am wearing of adding logs etc though maybe we can enable something in debug mode that will go away in release that would log when a message got rejected?