Closed cratelyn closed 4 months ago
debugged ci over in my fork here. pardon the noise, this should be ready for a review now!
@cratelyn sorry for the delay would you be able to resolve conflicts and then we can merge this?
@cratelyn sorry for the delay would you be able to resolve conflicts and then we can merge this?
@LucioFranco i sure can! :slightly_smiling_face: i've rebased this on the latest main
.
...and once more, rebased on main
!
this fixes #1685.
in penumbra-zone/penumbra#4392, we observed that tonic servers do not properly support reflection when servicing a request sent by recent versions of
grpcurl
, after v1.8.8 began usinggrpc.reflection.v1.ServerReflection
. (see fullstorydev/grpcurl#407)that leads to an error regarding an unexpected status code, like this:
this adds the v1 reflection definition to
tonic-reflection
, which was observed as fixing these issues for our gRPC endpoint.🩹 changes
changes in this commit are as follows:
vendors the
v1
definition ofreflection.proto
.renames the (deprecated)
v1alpha
definition toreflection_v1alpha.proto
.tonic_reflection::generated::grpc_reflection_v1
links to the generated Rust code (created by runningcargo run --package codegen
).tonic_reflection::generated::FILE_DESCRIPTOR_SET
is replaced bytonic_reflection::generated::{FILE_DESCRIPTOR_SET_V1ALPHA, FILE_DESCRIPTOR_SET_V1}
.tonic_reflection::pb
now contains namespacedtonic_reflection::pb::{v1alpha, v1}
submodules. (NB: this is a breaking change to the publictonic-reflection
API.)tonic_reflection::server
is updated to use the generatedtonic_reflection::pb::v1
code.fixes: #1685 x-ref: penumbra-zone/penumbra#4392